Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tune_cublaslt_gemm compile bug #8844

Merged
merged 3 commits into from
Jul 31, 2024
Merged

fix tune_cublaslt_gemm compile bug #8844

merged 3 commits into from
Jul 31, 2024

Conversation

yuanlehome
Copy link
Collaborator

@yuanlehome yuanlehome commented Jul 31, 2024 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Description

fix for #8799

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jul 31, 2024

Thanks for your contribution!

@yuanlehome yuanlehome changed the title fix tune_cublaslt_gemm fix tune_cublaslt_gemm compile bug Jul 31, 2024
DesmonDay
DesmonDay previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.43%. Comparing base (99d9bcb) to head (f24b4dd).

❗ Current head f24b4dd differs from pull request most recent head a59c897

Please upload reports for the commit a59c897 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8844   +/-   ##
========================================
  Coverage    55.43%   55.43%           
========================================
  Files          631      631           
  Lines        98544    98544           
========================================
  Hits         54632    54632           
  Misses       43912    43912

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DesmonDay
DesmonDay approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay DesmonDay merged commit d406e56 into PaddlePaddle:develop Jul 31, 2024
11 of 12 checks passed
DrownFish19 pushed a commit to DrownFish19/PaddleNLP that referenced this pull request Aug 2, 2024
@yuanlehome @DrownFish19
Fix tune_cublaslt_gemm compile bug (PaddlePaddle#8844)
af5cda2 
* fix tune_cublaslt_gemm

* Fix:

* fix
DrownFish19 pushed a commit to DrownFish19/PaddleNLP that referenced this pull request Aug 2, 2024
@yuanlehome @DrownFish19
Fix tune_cublaslt_gemm compile bug (PaddlePaddle#8844)
0e8cf65 
* fix tune_cublaslt_gemm

* Fix:

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DesmonDay DesmonDay DesmonDay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanlehome @DesmonDay